fix: disambiguate duplicate Verso labels in Section 4.2 - #651
Open
Chessing234 wants to merge 1 commit into
Open
Conversation
Seventeen docstrings across five groups shared a label, so the Verso documentation could not tell the declarations apart: Definition 4.2.1, Proposition 4.2.4, Lemma 4.2.7, Definition 4.2.8 and Proposition 4.2.9(a). Keep the statement name and fold the part into the parenthetical, e.g. (laws of algebra, field), matching the convention used for Proposition 9.3.14.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Section 4.2 has five groups of declarations sharing one docstring, so the Verso documentation cannot distinguish them:
Definition 4.2.1 (Rationals)— 2 declarationsProposition 4.2.4 (laws of algebra) / Exercise 4.2.3— 5 instancesLemma 4.2.7 (trichotomy of rationals) / Exercise 4.2.4— 4 theoremsDefinition 4.2.8 (Ordering of the rationals)— 2 instancesProposition 4.2.9(a) (order trichotomy) / Exercise 4.2.5— 4 theoremsSame fix as #624 for Proposition 9.3.14: keep the statement name and fold the part into the parenthetical, e.g.
(laws of algebra, field),(trichotomy of rationals, zero vs positive). Nothing outside the docstrings changes.Checked: no duplicate one-line docstrings remain in the file, and every edited line stays inside the 100-character limit.
lake build Analysis.Section_4_2succeeds locally —✔ [3265/3265] Built Analysis.Section_4_2 (87s),Build completed successfully.