fix: disambiguate duplicate Verso labels in Section 6.2 - #654
Open
Chessing234 wants to merge 1 commit into
Open
Conversation
Eleven docstrings across three groups shared a label: Definition 6.2.3, Examples 6.2.4 and Definition 6.2.6. The two ordering definitions and the five supremum cases name what they cover; the four examples take part letters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Section 6.2 has three groups of declarations sharing one docstring:
Definition 6.2.3 (Ordering of extended reals)— 2 (the≤and<characterisations)Examples 6.2.4— 4 examplesDefinition 6.2.6— 5 theorems covering the different supremum casesSame convention as #624: the definitions name the case they cover (
(supremum of the empty set),(supremum ignores negative infinity), …), the examples take part letters as in #634. Docstrings only.Checked: no duplicate one-line docstrings remain, all edited lines within 100 characters.
lake build Analysis.Section_6_2succeeds locally —Build completed successfully (3273 jobs). The oneinfo:line it prints is a pre-existing#check-style trace atSection_6_2.lean:177, unrelated to this change.