fix: disambiguate duplicate Verso labels in Section 5.6 - #655
Open
Chessing234 wants to merge 1 commit into
Open
Conversation
Twenty-one docstrings across eight groups shared a label: the analogues of Propositions 4.3.10(a), 4.3.10(c), 4.3.12(a) and 4.3.12(b), and Lemmas 5.6.6(c), 5.6.6(e), 5.6.9(b) and 5.6.9(e). Each now names what it covers - sum of exponents, power of a product, base greater than one, and so on - keeping the statement number intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Section 5.6 has eight groups of declarations sharing one docstring:
Analogue of Proposition 4.3.10(a)— 3 (pow_add,pow_mul,mul_pow)Analogue of Proposition 4.3.10(c)— 4 (nonnegativity, positivity, non-strict and strict monotonicity)Analogue of Proposition 4.3.12(a)— 3 (thezpowversions of the above)Analogue of Proposition 4.3.12(b)— 2Lemma 5.6.6 (c) / Exercise 5.6.1— 2Lemma 5.6.6 (e) / Exercise 5.6.1— 3Lemma 5.6.9(b) / Exercise 5.6.2— 2Lemma 5.6.9(e) / Exercise 5.6.2— 2#616 disambiguated the Chapter 5.4/5.6 exercise labels; these are the statement labels in the same file. Each now names the case it covers while keeping the statement number. Docstrings only.
Checked: no duplicate one-line docstrings remain, all edited lines within 100 characters.
lake build Analysis.Section_5_6succeeds locally —✔ [3271/3271] Built Analysis.Section_5_6 (39s),Build completed successfully.