Repository navigation
Compile once for the whole repository - #1496
Closed
cristianrgreco wants to merge 1 commit into
Closed
cristianrgreco wants to merge 1 commit into
cristianrgreco wants to merge 1 commit into
Conversation
cristianrgreco
added this pull request to stack #1498
October 10, 2026 20:35
cristianrgreco
commented
Oct 11, 2026
Replace the per-module compile matrix with one job that runs `npm run check-compiles`, a project-references build of every package. npm-setup installs every workspace when it isn't given one.
cristianrgreco
removed this pull request from stack #1498
October 11, 2026 18:15
cristianrgreco
force-pushed
the
claude/lint-whole-repo
branch
from
October 11, 2026 18:15
90f0ac2 to
ad7c93b
Compare
cristianrgreco
force-pushed
the
claude/compile-whole-repo
branch
from
October 11, 2026 18:15
26288f4 to
a93d924
Compare
cristianrgreco
added this pull request to stack #1501
October 11, 2026 18:15
This was referenced Oct 11, 2026
cristianrgreco
removed this pull request from stack #1501
October 11, 2026 18:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folded into #1495.
Stacked on #1495. Review and merge that one first.
Summary
Replaces the per-module compile matrix with one
Compilejob that runsnpm run check-compiles(tsc -b packages/testcontainers packages/modules/*).tsconfig.json, the same file the matrix jobs used.npm-setup:workspaceis now optional. Left empty, it installs every workspace and caches the result under anall-workspaceskey. The Compile job uses this. Existing callers and their cache keys are unchanged.Lint.Why
A clean whole-repository build takes about 1.7s locally. On a recent all-green run of
Checks, compiling took 44 jobs and 415s of runner time, because every job rebuilttestcontainersbefore checking its own module.It doesn't catch more type errors than before. No module depends on another module, and a change to
testcontainersor a shared file already recompiled every package.Verification
npm run check-compilesfrom a clean state: passes.packages/modules/redis/src, it exits 2 and reportsTS2322for that file.npm-setupchange is identical to the one in Detect unused code and dependencies with knip #1492, where it ran on CI: the first run missed and saved theall-workspacescache (npm citook 35s), and the next run restored it (install step 11s).checks.ymlandaction.ymlparse.npm run format: no fixes applied.Checksruns on this PR as part of the stack. An earlier revision of this change passed it in full, with the singleCompilejob and all 176 test jobs green.Why this isn't breaking
CI-only. No package source, dependency or published file changes.
The check name changes from
Compile (<module>)toCompile.mainhas no branch protection or required status checks, so nothing needs updating.