Repository navigation
Conversation
Add cases to the feedback host-copier and alh-copier for the case that AMP_FEEDBACK_CH=1. This is for configurations that have a single mono amp, or a stereo amp that produces a mono feedback. Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Adds PTL topologies for a single CS35L56 type amp with mono feedback. This includes the variants with 2ch and 4ch host DMICs. Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
PR 11275: test resultsRun date: 2026-10-06 14:44 UTC Tested commit: 0439a33411345aa057fec0a36ac6aeb0d04b64d8
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new targets omit required PTL platform selection, and the DMIC variants also omit NHLT generation.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Adds mono amplifier-feedback support and PTL topology targets for a solo CS35L56.
Changes:
- Adds mono feedback audio formats and channel mappings.
- Registers three PTL variants with optional 2/4-channel PCH DMICs.
| File | Description |
|---|---|
tools/topology/topology2/production/tplg-targets-ace3.cmake |
Adds three CS35L56 PTL targets. |
tools/topology/topology2/platform/intel/sdw-amp-generic.conf |
Supports one-channel amplifier feedback. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| SDW_JACK_OUT_STREAM=SDW3-Playback,SDW_JACK_IN_STREAM=SDW3-Capture,\ | ||
| PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-ptl-rt713-l3-rt1320-l1-2ch.bin" | ||
|
|
||
| "cavs-sdw\;sof-ptl-cs35l56-fb1\;NUM_SDW_AMP_LINKS=1,SDW_DMIC=0,SDW_JACK=false,\ |
Comment on lines
+191
to
+192
| "cavs-sdw\;sof-ptl-cs35l56-fb1-2ch\;NUM_SDW_AMP_LINKS=1,SDW_DMIC=0,SDW_JACK=false,\ | ||
| NUM_DMICS=2,PDM1_MIC_A_ENABLE=0,PDM1_MIC_B_ENABLE=0,DMIC0_ID=4,DMIC1_ID=5,\ |
bardliao
reviewed
Oct 7, 2026
| NUM_DMICS=2,PDM1_MIC_A_ENABLE=0,PDM1_MIC_B_ENABLE=0,DMIC0_ID=4,DMIC1_ID=5,\ | ||
| SDW_AMP_FEEDBACK=true,SDW_SPK_STREAM=Playback-SmartAmp,SDW_SPK_IN_STREAM=Capture-SmartAmp,\ | ||
| AMP_FEEDBACK_CH=1,AMP_FEEDBACK_CH_PER_LINK=1,\ | ||
| HDMI1_ID=6,HDMI2_ID=7,HDMI3_ID=8" |
Collaborator
There was a problem hiding this comment.
We need to include the NHLT blob in the topology for the -2ch and -4ch variants in case the NHLT blob is missing in the BIOS. Like PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-ptl-cs35l56-fb1-2ch.bin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for mono amp feedback and adds three PTL topologies for a solo CS35L56 with mono feedback.