Repository navigation
Fix dig to inline options - #66
Merged
Merged
Conversation
Digging to a node written with an inline options object, e.g.
`json.cart(with.partial("cart"))`, rendered nothing: the found node is
only rendered when it has a block, and an inline options node has none.
Its content comes from the options, so render it when those are a
Props::Options too.
Digging through such a node into its partial already worked, which is
what the existing specs covered.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
found_path! sliced the found path by the length of the fragment path, which is only set when the dig crosses a fragment. Any other dig, or calling it without digging, raised NoMethodError on nil. superglue's layout calls it on every props_at request, so digs into plain nodes returned a 500. Fall back to an empty fragment path, which returns the full path the client grafts onto the page, as found_path! did before 4183fd0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.