Repository navigation
Conversation
BoTxnNotFound, BoMaxTsNotSynced, BoCommitTSLag and BoMaxRegionNotInitialized shared one observer with an empty type label, which Grafana shows as a series called "Value". Each now reports under its config name. BackoffHistogramEmpty is removed; nothing else in this module used it. close tikv#1802 Signed-off-by: phatlc <phatle.hsd@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @hsdfat. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @hsdfat! |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
close #1802
Four backoff configs (
BoTxnNotFound,BoMaxTsNotSynced,BoCommitTSLag,BoMaxRegionNotInitialized) sharedmetrics.BackoffHistogramEmpty, an observer of the backoff histogram with an emptytypelabel. Grafana renders that series as "Value", so these backoffs could not be told apart, or recognised at all.Each config now has its own observer, labelled with the name the config already has:
txnNotFound,maxTsNotSynced,commitTSLag,regionNotInitialized. This is the shape of #1862, which was approved once and then closed by its author.Compatibility:
metrics.BackoffHistogramEmptyis removed. Nothing else in this module referenced it. If a downstream project uses it, I can keep it as a deprecated alias instead; say the word. Dashboards that selecttype=""need the new label values.Test:
TestBackoffConfigsHaveNamedMetricchecks that a backoff of each of the four configs is counted under its own name and that no series with an emptytypelabel exists. It fails on master and passes with this change.go test --tags=intest -race ./config/retry/andgolangci-lint run ./config/... ./metrics/...are clean.AI assistance: I used an AI assistant while writing this change and reviewed and tested it myself.
Summary by CodeRabbit