Skip to content

integration_tests: use the merged TiDB release-nextgen-202603 commit - #2172

Merged
ti-chi-bot[bot] merged 1 commit into
tikv:release-nextgen-202603from
JmPotato:integration-tests-tidb-pin-2603
Nov 13, 2026
Merged

ti-chi-bot[bot] merged 1 commit into
tikv:release-nextgen-202603from
JmPotato:integration-tests-tidb-pin-2603

Conversation

@JmPotato

@JmPotato JmPotato commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

ref pingcap/tidb#73004

What changed

integration_tests now depends only on a commit in pingcap/tidb release-nextgen-202603, not on a temporary bot-branch commit.

The github.com/tikv/client-go/v2 require line moves to 5515e20451af (client-go#2126) because TiDB at 7098f3c44780 requires that version. The module still replaces client-go with ../, so this does not change what the tests build.

Summary by CodeRabbit

Chores

  • Updated the integration test environment to use newer upstream components and removed temporary source overrides. The existing local configuration for the storage client remains in place.
  • These changes are limited to test infrastructure. No changes to the application’s visible features, workflows, or behavior are included.

Drop the replace directives that pointed github.com/pingcap/tidb and
github.com/pingcap/tidb/pkg/parser at a ti-chi-bot/tidb branch commit,
and require pingcap/tidb 7098f3c44780, the merge commit of
pingcap/tidb#73004 on release-nextgen-202603. Its unistore PD client
implements LoadKeyspaceByID, which pd.Client requires since tikv#2126.

Signed-off-by: JmPotato <github@ipotato.me>
@ti-chi-bot ti-chi-bot Bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 13, 2026
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The integration_tests module updates its TiDB and TiKV client-go dependency revisions. It also removes replacement directives for TiDB and its parser.

Changes: Integration test dependencies

Layer / File(s) Summary
Dependency pins and module resolution
integration_tests/go.mod
The module updates the TiDB and TiKV client-go versions, aligns the indirect TiDB parser version with TiDB, and removes the TiDB and parser replacement directives.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Possibly related PRs

  • tikv/client-go#2126: It updates the integration_tests TiDB dependency to address the same missing-method issue.

Suggested reviewers: disksing, lcwangchao, cfzjywxk

Merge Risk: Minimal · up to 465f9

This updates test-only dependency pins and removes temporary replace directives. It does not affect production behavior, and no merge-blocking risk was identified. CI should confirm the integration tests build.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: integration_tests now uses the merged TiDB release-nextgen-202603 commit. The raw summary confirms the go.mod bumps the tidb and tidb/pkg/parser dependencies to the 20…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: integration_tests now uses the merged TiDB release-nextgen-202603 commit. The raw summary confirms the go.mod bumps the tidb and tidb/pkg/parser dependencies to the 20261113041548-7098f3c44780 revision and removes the ti-chi-bot/tidb replace directives. The title is specific and matches the changeset and the stated PR objective.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2e102816-8029-4672-a542-d7b492b8754e
Commits

Reviewing files that changed from the base of the PR and between 5515e20 and 465f9f2.

Files ignored due to path filters: 1

  • integration_tests/go.sum is excluded by !**/*.sum
Files selected for processing: 1

  • integration_tests/go.mod

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 13, 2026
@JmPotato

Copy link
Copy Markdown
Member Author

/test pull-integration-test-release-nextgen

@ti-chi-bot

ti-chi-bot Bot commented Nov 13, 2026

Copy link
Copy Markdown

@JmPotato: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-test-release-nextgen 465f9f2 link false /test pull-integration-test-release-nextgen

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot

ti-chi-bot Bot commented Nov 13, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: disksing, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 13, 2026
@ti-chi-bot

ti-chi-bot Bot commented Nov 13, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-11-13 05:48:56.02540358 +0000 UTC m=+1423260.650553847: ☑️ agreed by rleungx.
  • 2026-11-13 07:09:09.968734628 +0000 UTC m=+1428074.593884900: ☑️ agreed by disksing.

@ti-chi-bot
ti-chi-bot Bot merged commit 116de16 into tikv:release-nextgen-202603 Nov 13, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants