Repository navigation
apicodec, resourcecontrol: decode StoreBatchCop response keys and settle batched task details (#2050, #2029) (tidb-8.5) - #2173
Conversation
ref pingcap/tidb#70665 (cherry picked from commit e490560) Signed-off-by: 0xPoe <poe.liu@pm.me>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
ref pingcap/tidb#67449 (cherry picked from commit 6667175) Signed-off-by: 0xPoe <poe.liu@pm.me>
|
@qw4990: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, JmPotato, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref pingcap/tidb#70665, ref pingcap/tidb#67449
Cherry-picks two fixes to
tidb-8.5for the TiDB release-8.5 backport of batched Analyze (pingcap/tidb#73139). One commit per source PR:DecodeResponse.What is changed and how does it work?
tidb-8.5does not haveTestDecodeResponseSecondWaveCommands, so its cases are in a newTestDecodeResponseStoreBatchAndSplitRegion.tidb-8.5has no NextGen read-byte rule and its kvproto has noTotalVersionsSize, so nested responses useProcessedVersionsSize, as the top-level response already does there.Tests
go test ./internal/apicodec ./internal/resourcecontrol ./internal/locate -count=1: passes. Without the source changes, the new cases fail.Summary by CodeRabbit