Repository navigation
Conversation
Pin RocksDB and Titan to zstd-sys 2.1.2, the minimum release fixing RUSTSEC-2026-0410 and supporting the patched zstd-safe 8.2.0 dependency chain. Both engines continue to share one libzstd build. Signed-off-by: Bisheng Huang <hbisheng@gmail.com>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
duplicated |
The current
zstd-sys <=2.0.13constraints prevent resolving the patchedzstd-safe 8.2.0/zstd 0.14.3dependency chain and retain RUSTSEC-2026-0410.Pin both RocksDB and Titan to
zstd-sys =2.1.2, the minimum patched release, so they continue to share one C library. This changes bundled libzstd from 1.5.6 to 1.5.7; the RocksDB and Titan source revisions stay unchanged. The exact pin keeps the existing bounded-upgrade policy without selecting future releases.Issue Number: ref tikv/tikv#20333
Validation:
cargo test --tests --no-default-featurespassed on macOS arm64 (48 unit tests and 136 integration tests).cargo-deny 0.18.9 check --show-statspass with the proposed dependency chain (0 advisory errors).The upper bound was introduced in #826; its PR discussion does not document the reason. This stays draft while native compatibility validation is incomplete.