Repository navigation
feat(release): create the next cycle's upgrade script at the bump - #432
Merged
Merged
Conversation
erimatnor
force-pushed
the
feature/bump-creates-upgrade-script
branch
from
November 20, 2026 19:40
8d1d820 to
7ec452b
Compare
CoverageTotal coverage: 92% |
erimatnor
force-pushed
the
feature/bump-creates-upgrade-script
branch
2 times, most recently
from
November 20, 2026 20:07
2fd21c2 to
e4aad4f
Compare
The pull request that reopens the development cycle after a final release now also creates the upgrade script for the new cycle, with no statements, and lists it in the build. Until now a cycle started with no script, and the upgrade test had nothing to run. The release-cycle check admits that script and its list entry in a bump besides VERSION, and requires them after a final release. The script has to be what the tool writes, and the build file may gain only its entry. A candidate's bump still changes VERSION alone, since its cycle's script is already pending. The bump is opened while the release is still a draft, whose tarball cannot be downloaded. build-release.sh then builds the previous release from its tag, so the upgrade test can run on the bump. build-release.sh downloads through gh when GH_TOKEN is set, which a private copy of the repository needs, and the workflow passes its token.
erimatnor
force-pushed
the
feature/bump-creates-upgrade-script
branch
from
November 20, 2026 20:14
e4aad4f to
a5df93f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pull request that reopens the development cycle after a final release now also creates the upgrade script for the new cycle, with no statements, and lists it in the build. Until now a cycle started with no script, and the upgrade test had nothing to run.
The release-cycle check admits that script and its list entry in a bump besides VERSION, and requires them after a final release. The script has to be what the tool writes, and the build file may gain only its entry. A candidate's bump still changes VERSION alone, since its cycle's script is already pending.
The bump is opened while the release is still a draft, whose tarball cannot be downloaded. build-release.sh then builds the previous release from its tag, so the upgrade test can run on the bump.