Skip to content

feat(release): create the next cycle's upgrade script at the bump - #432

Merged
erimatnor merged 1 commit into
mainfrom
feature/bump-creates-upgrade-script
Nov 20, 2026
Merged

erimatnor merged 1 commit into
mainfrom
feature/bump-creates-upgrade-script

Conversation

@erimatnor

Copy link
Copy Markdown
Member

The pull request that reopens the development cycle after a final release now also creates the upgrade script for the new cycle, with no statements, and lists it in the build. Until now a cycle started with no script, and the upgrade test had nothing to run.

The release-cycle check admits that script and its list entry in a bump besides VERSION, and requires them after a final release. The script has to be what the tool writes, and the build file may gain only its entry. A candidate's bump still changes VERSION alone, since its cycle's script is already pending.

The bump is opened while the release is still a draft, whose tarball cannot be downloaded. build-release.sh then builds the previous release from its tag, so the upgrade test can run on the bump.

@erimatnor
erimatnor force-pushed the feature/bump-creates-upgrade-script branch from 8d1d820 to 7ec452b Compare November 20, 2026 19:40
@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Coverage

Total coverage: 92%

Full report

@erimatnor
erimatnor force-pushed the feature/bump-creates-upgrade-script branch 2 times, most recently from 2fd21c2 to e4aad4f Compare November 20, 2026 20:07
The pull request that reopens the development cycle after a final
release now also creates the upgrade script for the new cycle, with
no statements, and lists it in the build. Until now a cycle started
with no script, and the upgrade test had nothing to run.

The release-cycle check admits that script and its list entry in a
bump besides VERSION, and requires them after a final release. The
script has to be what the tool writes, and the build file may gain
only its entry. A candidate's bump still changes VERSION alone,
since its cycle's script is already pending.

The bump is opened while the release is still a draft, whose
tarball cannot be downloaded. build-release.sh then builds the
previous release from its tag, so the upgrade test can run on the
bump.

build-release.sh downloads through gh when GH_TOKEN is set, which
a private copy of the repository needs, and the workflow passes its
token.
@erimatnor
erimatnor force-pushed the feature/bump-creates-upgrade-script branch from e4aad4f to a5df93f Compare November 20, 2026 20:14
@erimatnor
erimatnor merged commit d92fbf3 into main Nov 20, 2026
31 checks passed
@erimatnor
erimatnor deleted the feature/bump-creates-upgrade-script branch November 20, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant