Repository navigation
Re-align WWW_Users and UserSettings - #1016
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's try this again. This PR resolves #1013 by re-aligning WWW_Users and UserSettings, and in the process replace the PageSize used in WWW_Users.php (7 near-identical if/else blocks and 14 echo statements) with a $PageSizes value→label array and foreach loop, and use the same pattern in UserSettings.php. The result is 70% less code per file and adding/removing a page size now only requires editing one array entry instead of duplicating an if/else block. This implementation was suggested by @timschofield in a comment to the original and now abandoned PR #1015 ("Would it be more efficient to store the page sizes in an array, and then create the options by cycling through the array?")