Repository navigation
Type aliases, list splats, generic types and f-strings - #320
vanessa-rodrigues wants to merge 2 commits into
Conversation
|
By the way, the tests are failing on the Node binding. I haven’t made any changes to them (and don’t actively use them), so I’m not sure what’s causing the failures. The grammar updates fix several bugs, and I wanted to contribute those improvements back—happy to help investigate if you have guidance. |
vanessaabigailirachetamonterre-del
left a comment
vanessaabigailirachetamonterre-del
left a comment
There was a problem hiding this comment.
vanessa-rodrigues:parsing_errors
|
Hi @vanessa-rodrigues, thanks for this contribution! Like various other grammars in this organization, this repository doesn't seem to be actively maintained. A few community members and I have been maintaining forks of those repos, where we integrate good contributions like this one. I've done so for this PR in If you encounter any issue switching to the fork as a user or contributor, do let me know :) |
Fix conflict between type_alias_statement and primary_expression.
Fix several parsing errors related to list splats, f-strings and generic types. All tests were added to corpus.
Add some fields throughout the grammar and fix a typo (?) on the type_parameters rule, renaming it from type_parameter.