fix(knowledge): permit exact committed TreeDX publication retries - #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Allow an unchanged Identity Guide revision to retry publication after upstream credential recovery.
Work authority
Contributor mode:
Plan
Match TreeDX's actual immutable committed-workspace contract, not Git working-tree assumptions. Require committed state, exact reviewed commit, matching diff paths and matching retained overlay paths. Reject ready/expired state and unexpected paths.
Changes and commits
Replace incorrect empty-overlay requirement with exact committed-state validation. TreeDX files.ex preserves overlays after commit and denies writes unless ready; no TreeDX mutation or policy bypass.
Verification
33 knowledge tests (10 files) and independent build pass locally. Actions Verify 34369370996 passed; final submission contract 34369431962 and authorization 34369431975 passed.
Risk and rollback
No credential bypass: GitHub 401 still requires service credential renewal. No live activation or direct library push. Revert this bounded admission change before adoption; preserve the submitted workspace and commit.
Completion summary
Fix implemented and automated gates passed. Identity Guide remains unpublished until upstream credential recovery and managed rollout of this fix.
AGPL committer authorization
Existing base-owned authenticated contributor checks apply.
Submission checklist