fix: enforce gRPC HTTP/2 stream limits#6887
Closed
lxcmyf wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
4.1.135.Finalto consume the upstream fixes for CVE-2026-47244 and CVE-2026-50560maxConcurrentCallsPerConnectionon Netty's remote HTTP/2 endpoint before grpc-java installs its handler0fallback behaviorREFUSED_STREAMRoot cause
grpc-java 1.81.0 creates
DefaultHttp2Connectiondirectly instead of using Netty'sHttp2ConnectionHandlerBuilder. It advertisesSETTINGS_MAX_CONCURRENT_STREAMS, but does not apply the same value toconnection.remote().maxActiveStreams(). As a result, the Netty builder-side fix for CVE-2026-47244 is bypassed.java-tron now wraps grpc-java's plaintext protocol negotiator and configures the connection before the gRPC handler enters the channel pipeline. The original negotiator still handles the rest of protocol setup.
Impact
0also selects the secure default of 100Validation
./gradlew :common:test --tests org.tron.core.config.args.NodeConfigTest :framework:test --tests org.tron.common.application.GrpcNettyMaxConcurrentStreamsLimiterTest --tests org.tron.core.config.args.ArgsTest./gradlew :framework:checkstyleMain./gradlew :framework:dependencyInsight --dependency netty-codec-http2 --configuration runtimeClasspathResolved runtime dependencies:
io.grpc:grpc-netty:1.81.0io.netty:netty-codec-http2:4.1.135.Final