Repository navigation
Fix Aid::category and length validation in constructors and release v0.2.1 - #35
Merged
Merged
Conversation
This patch fixes two connected bugs: - Aid::category checked for ASCII characters instead of raw bytes, classifying almost all AIDs a Category::Other. - Aid::try_new_truncatable (also called by all other constructors) enforced a maximum length instead of a minimum length for national and international AIDs. Due to the bug in Aid::category, this had virtually no effect though.
robin-nitrokey
requested review from
0x0ece,
daringer and
sosthene-nitrokey
September 20, 2026 19:22
sosthene-nitrokey
approved these changes
Sep 21, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two connected bugs:
Aid::categorychecked for ASCII characters instead of raw bytes, classifying almost all AIDs asCategory::Other.Aid::try_new_truncatable(also called by all other constructors) enforced a maximum length instead of a minimum length for national and international AIDs. Due to the bug inAid::category, this had virtually no effect though.This first bug was already present in the first release. The second bug was introduced when inverting a condition in 4b73fa5.
This PR fixes both issues and adds tests using some well-known AIDs and the AIDs used on the NK3. Technically this is a breaking change but as the previous behavior was obviously wrong, I think it is semver-compliant to publish these fixes in a patch release.