CS-469 [BUG] - Inactive users to not be shown as an option when assigning Evidence tasks. All "Inactive" users should be hidden.

[github-actions]

This is an automated pull request to merge chas/task-assignee into dev.
It was created by the [Auto Pull Request] action.

---

Summary by cubic

Hides inactive and deactivated users from assignee dropdowns and API results when includeDeactivated is false, per CS-469. Also sorts visible assignees alphabetically by name (fallback to email) for a cleaner picker.

^{Written for commit 01a86c3. Summary will update on new commits.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
app	Ready	Preview, Comment	Jul 6, 2026 3:32pm
comp-framework-editor	Ready	Preview, Comment	Jul 6, 2026 3:32pm
portal	Ready	Preview, Comment	Jul 6, 2026 3:32pm

[linear]

CS-469

[chasprowebdev]

@cubic-dev-ai please review it.

[cubic-dev-ai]

1 issue found and verified against the latest diff

Confidence score: 3/5

• In apps/api/src/people/utils/member-queries.ts, the new isActive: true list filter can diverge from findByIdInOrganization behavior, so the same member may be hidden in list views but still retrievable by ID, leading to inconsistent API/UI behavior after merge — align the query predicates across list and by-ID paths (or explicitly enforce/validate impossible states) before merging.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/api/src/people/utils/member-queries.ts">

<violation number="1" location="apps/api/src/people/utils/member-queries.ts:69">
P2: Adding `isActive: true` to the list filter creates an inconsistency: members with `isActive: false` but `deactivated: false` (if such a state exists) are excluded from the list but still returned by `findByIdInOrganization`. Either both methods should apply the same filter, or the logic needs a clear invariant enforced elsewhere.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic</sub>

[cubic-dev-ai]

P2: Adding isActive: true to the list filter creates an inconsistency: members with isActive: false but deactivated: false (if such a state exists) are excluded from the list but still returned by findByIdInOrganization. Either both methods should apply the same filter, or the logic needs a clear invariant enforced elsewhere.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At apps/api/src/people/utils/member-queries.ts, line 69:

<comment>Adding `isActive: true` to the list filter creates an inconsistency: members with `isActive: false` but `deactivated: false` (if such a state exists) are excluded from the list but still returned by `findByIdInOrganization`. Either both methods should apply the same filter, or the logic needs a clear invariant enforced elsewhere.</comment>

<file context>
@@ -66,7 +66,7 @@ export class MemberQueries {
       where: {
         organizationId,
-        ...(includeDeactivated ? {} : { deactivated: false }),
+        ...(includeDeactivated ? {} : { deactivated: false, isActive: true }),
         ...(filters?.onboardAfter || filters?.onboardBefore
           ? {
</file context>

[cubic-dev-ai]

@cubic-dev-ai please review it.

@chasprowebdev I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 2 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}