Conversation
|
|
|
coverage: 99.59% (+0.002%) from 99.588% — lenamonj:compactcells-duplicate-input into uber:master |
isaacbrodsky
requested review from
ajfriend,
dfellis,
dmitryzv,
isaacbrodsky,
jongbinjung and
nrabinowitz
September 7, 2026 01:02
compactCells counted how many times each parent was produced, not how many distinct children it saw, so a set that repeated one child could reach a full count of seven and compact to a parent the input never covered, silently returning a superset of the caller's region. Duplicates are now rejected up front with the documented E_DUPLICATE_INPUT. The former parentError2 fixture repeated values and is re-pointed at that code; a new mixed-resolution fixture keeps the parent-count overflow branch covered. Docs and CHANGELOG updated.
lenamonj
force-pushed
the
compactcells-duplicate-input
branch
from
September 13, 2026 17:47
08dcfcd to
5c1c143
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compactCellscounted how many times each parent was produced, not how many distinct children it saw, so an input that repeated one child six times and added a second child reached a count of seven and compacted to a parent the input never covered: the call returned a superset of the caller's region withE_SUCCESS.Duplicates are now rejected up front with the documented
E_DUPLICATE_INPUT, after sorting a private copy of the input.compactCells_duplicateIgnored, which pinned the old behaviour, becomescompactCells_duplicateRejected; theparentError2fixture repeated values and is re-pointed at that code; a new mixed-resolution fixture keeps the parent-count overflow branch covered. Docs and CHANGELOG updated.