Publish Plugins Manager 2.0 and switch the release command - #873
Merged
Conversation
Add the 2.0 entry to the manager's own repository index. It loads the repository several times faster and halves the download size. The changes text carries "Requires JMeter 3.2+" because the repo format has no way to express a version constraint - every user is offered the highest version regardless. 3.2 is the real floor: the shipped jar references no JMeter or jorphan class or method newer than 3.2, and the source still compiles against JMeter 3.2 with its log4j 2.8.2, even though the project now builds against 5.0. maven-bundle.sh moves to `mvn -Psonatype-oss-release clean deploy`. The previous command re-entered the lifecycle once per phase argument, so compile, jar and shade each ran two or three times over, and gpg signing was invoked by hand rather than bound to verify. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes, both fallout from releasing jmeter-plugins-manager 2.0 to Central.
self.json— the 2.0 entry2.0 loads the repository several times faster and halves the download:
load()coldload()warmWhy the changes text says "Requires JMeter 3.2+"
The repo format has no way to express a version constraint — every user is offered the highest version regardless — so the
changesstring is the only channel that reaches the UI.3.2 is the real floor, verified three ways against the shipped jar:
org.apache.jmeter/org.apache.jorphanclasses exist in 3.2src/maincompiles clean against JMeter 3.2 with its log4j 2.8.2The project now builds against 5.0, but nothing in the artifact requires it. Worth knowing that the two numbers disagree deliberately.
Residual risk
Users below JMeter 3.2 — roughly the 0.3% band on the usage stats — will be offered an upgrade whose manager won't load, and
canUninstallisfalse, so there's no UI path back. Small, but unpleasant for whoever hits it.maven-bundle.shThe old form re-entered the lifecycle once per phase argument, so compile, jar and shade each ran two or three times over, and
gpg:signwas invoked by hand instead of bound toverify.-Dadditionalparam=-Xdoclint:nonewas inert (a javadoc 2.x flag) and is now handled in the manager's POM;-Dpackaging=jarwas redundant. This form also runs the tests, which the old one skipped.