Skip to content

fix: exclude credential secret from Azure KbsConfig #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
butler54 wants to merge 1 commit into from
Closed

fix: exclude credential secret from Azure KbsConfig #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions overrides/values-trustee-azure.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,19 @@ kbs:
abiMinor: "31"
singleSocket: "false"
smtAllowed: "true"

# trustee-chart's default kbs.extraSecrets (["credential"]) is unconditionally
# added to KbsConfig.spec.kbsSecretResources, but the ACM ConfigurationPolicy
# that creates that Secret (pull-secret-credential-policy.yaml) is skipped on
# Azure -- peer-pod CDH doesn't fetch registry credentials from KBS there
# (pull secrets are distributed to workload namespace SAs instead, see
# sandboxed-policies-chart/pull-secret-distribution.yaml). Without this
# override, KbsConfig lists a Secret ("credential") that never gets created,
# and the kbsconfig-controller fails to deploy KBS with:
# Error in creating/updating KBS deployment: Secret "credential" not found
#
# Fixed upstream in trustee-chart (kbs.yaml now gates extraSecrets the same
# way as the policy) -- see validatedpatterns/trustee-chart#42. This
# override can be dropped once coco-pattern picks up a trustee chartVersion
# that includes that fix (>= 0.10.1, pending release).
extraSecrets: []
Loading