Repository navigation
Conversation
dw-kihara
force-pushed
the
fix/xss-on-demo-page-2
branch
from
November 16, 2026 07:27
3e2ee81 to
47c7c4d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix XSS by escaping error messages in demo page.
Why is this Pull Request needed?
#6538 addressed the XSS by validating the stream URL. Unfortunately, that fix cannot prevent a valid but malicious URL like
https://example.invalid/<script>alert("xss")</script>. Additionally, a malicious response might cause XSS in the error message.Example: https://hlsjs-dev.video-dev.org/demo/?src=https://example.invalid/%3Cscript%3Ealert(%22xss%22)%3C/script%3E
Are there any points in the code the reviewer needs to double check?
Nothing specific.
Checklist