Repository navigation
fix: EXT-X-DEFINE variable names colliding with Object.prototype - #8190
Open
istiakrahman15 wants to merge 3 commits into
Open
istiakrahman15 wants to merge 3 commits into
istiakrahman15 wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Pull Request needed?
src/utils/variable-substitution.tsstored EXT-X-DEFINE variables in a plain{}object and tested names with theinoperator, so names that exist onObject.prototypeleaked through:NAME="constructor"once falsely reported a duplicate variable, because"constructor" in {}is true via the prototype, and the nativeObject()source text could end up substituted into a URI.{$toString}produced no parsing error — nativeObject.prototype.toStringsource was substituted instead.Per RFC 8216bis,
constructoris a legal Variable Name, and an undefined variable reference must be a parsing error.This PR will...
Change only the two places where the variable list is created, in
src/utils/variable-substitution.ts(lines 55 and 100, inaddVariableDefinitionandimportVariableDefinition):With a null-prototype map,
inreturns false for prototype names and bracket access returnsundefinedfor undefined names, so the existing error branches fire correctly.It also adds regression tests in
tests/unit/loader/m3u8-parser.ts, following the existing#EXT-X-DEFINEtests:constructoronce — no duplicate error, and{$constructor}/segment.tsresolves tohttps://cdn1.example/segment.ts{$toString}— a parsing error:Missing preceding EXT-X-DEFINE tag for Variable Reference: "toString"Resolves issues:
Fixes #8187
Checklist