Repository navigation
2020 09 09 - #10
Merged
Merged
2020 09 09#10
Conversation
…sent Root cause: scripts/vbd-artifacts.js, package.json, and related npm tooling referenced by vbd-analysis.yml were never added to this revision (verified via git log --all). npm run failed with ENOENT because there is no root package.json to read, not because of a wrong working directory. Fix: detect package.json presence in a dedicated step and gate every npm run step on it, mirroring the existing docs/analysis validate-if-present pattern. The workflow now degrades gracefully until the Node.js toolchain is committed, instead of failing CI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… CI gates Builds the missing Node.js tooling referenced by vbd-analysis.yml so the workflow no longer needs the toolchain-presence guard added earlier: - scripts/vbd-artifacts.js: dependency-free CLI (init/validate/graph/ plan/score/dashboard/checkpoint) for docs/analysis VBD artifacts. - scripts/tests/vbd-artifacts.test.js: node:test coverage for the CLI. - scripts/validate-frontmatter.js: enforces .github/instructions/frontmatter-standard.instructions.md across .github/**/*.md and docs/**/*.md, with a --self-test fixture suite. - scripts/sync-solution-markdown.js: verifies vc.Ifx.slnx tracks every .github/**/*.md file, with a --self-test fixture suite. - vc.Ifx.slnx: adds the 617 previously-untracked .github/instructions, .github/prompts, and .github/skills markdown files. - .github/workflows/vbd-analysis.yml: removes the temporary toolchain-detection guard now that package.json exists; every npm run step executes unconditionally again. Also brings the full repository into frontmatter-standard compliance (73 files were missing required title/doc_type/status/last_updated front matter or used a disallowed doc_type), since frontmatter:validate is now an enforced, non-skippable CI gate. Verified locally: npm run vbd:artifacts:test, frontmatter:test, solution:markdown:test, vbd:analysis:validate, frontmatter:validate, and solution:markdown:check all exit 0. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…into 2020-09-09 Merging
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
vc.Ifx.slnx now contains an added .github block but still retains obsolete .github/*.instructions.md entries (nonexistent paths), leaving broken solution references that should be consolidated/updated.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR expands repository validation and governance tooling (Node-based VBD artifact automation, Markdown front matter validation, and solution/Markdown synchronization), fixes CI portability gaps in unit/provenance tests, and normalizes documentation metadata by adding front matter across many docs and .github instruction files.
Changes:
- Add Node tooling and CI workflow wiring for VBD artifact validation, front matter validation, and solution-markdown drift checks.
- Fix build provenance verification to include hidden output files and strengthen provenance regression coverage for hidden-file scenarios.
- Make unit tests portable across Windows/Linux (path handling, file-lock/delete semantics, and generator harness source discovery) and add front matter to documentation/instruction markdown.
File summaries
| File | Description |
|---|---|
| vc.Ifx.slnx | Adds solution entries for .github instruction/prompt/skill content and related docs. |
| tests/unit/vc.Ifx.UnitTests/Storage/StorageServiceTests.cs | Makes path-based tests platform-independent via Path.GetFullPath. |
| tests/unit/vc.Ifx.UnitTests/Storage/Local/LocalStorageProviderTests.cs | Updates delete semantics assertions to match platform behavior for open files. |
| tests/unit/vc.Ifx.UnitTests/Storage/Ftp/FtpStorageProviderTests.cs | Adjusts path fixtures to be OS-aware and aligns invalid-path test data with provider validation. |
| tests/unit/vc.Ifx.UnitTests/Generators/Implementation/GeneratorHarness.cs | Removes CallerFilePath dependency; locates repo root from test output paths for CI portability. |
| tests/unit/vc.Ifx.UnitTests/Authentication/TenantContextTests.cs | Clarifies thread-safety expectations by adding caller-owned synchronization in the test. |
| tests/infrastructure/provenance/Test-BuildProvenance.ps1 | Improves hidden-file mutation/cleanup handling and adds coverage for hidden outputs and absent hidden inputs. |
| scripts/vbd-artifacts.js | Introduces a CLI for initializing/validating/analyzing VBD artifact trees (validate/graph/plan/score/dashboard/checkpoint). |
| scripts/validate-frontmatter.js | Adds a dependency-free front matter validator (with a self-test mode) for .github and docs. |
| scripts/tests/vbd-artifacts.test.js | Adds Node test coverage for the vbd-artifacts CLI behaviors. |
| scripts/testing/BuildProvenance.psm1 | Includes hidden files in live output inventory checks to match recorded manifests. |
| scripts/sync-solution-markdown.js | Adds a checker ensuring .github/.copilot markdown files are tracked in vc.Ifx.slnx (with self-tests). |
| README.md | Updates narrative to reference hosted follow-up evidence and clarify publication was not performed. |
| package.json | Defines npm scripts to run the new Node tooling and tests (Node >= 20). |
| docs/webapi/http-response-catalog.md | Adds required front matter metadata. |
| docs/testing/multi-source-selection-verification.md | Adds required front matter metadata. |
| docs/testing/initial-unit-baseline-2026-09-09.md | Adds required front matter metadata. |
| docs/testing/build-provenance.md | Adds required front matter metadata. |
| docs/roslyn/minimal-api-generator-contract.md | Adds required front matter metadata. |
| docs/roslyn/diagnostic-debt-analyzer.md | Adds required front matter metadata. |
| docs/roslyn/diagnostic-catalog.md | Adds required front matter metadata. |
| docs/roslyn/code-fix-support-matrix.md | Adds required front matter metadata. |
| docs/reviews/system-map.md | Adds required front matter metadata. |
| docs/reviews/release-checklist.md | Adds required front matter metadata. |
| docs/reviews/readme.md | Adds required front matter metadata. |
| docs/reviews/quarterly-radar-review.md | Adds required front matter metadata. |
| docs/reviews/branching-strategy.md | Adds required front matter metadata. |
| docs/reporting/verification.md | Adds required front matter metadata. |
| docs/reporting/report-contract.md | Adds required front matter metadata. |
| docs/reporting/README.md | Adds required front matter metadata. |
| docs/planning/local-verification-20260910.md | Adds required front matter metadata. |
| docs/planning/implementation-progress.md | Adds required front matter metadata. |
| docs/planning/implementation-acceptance-audit.md | Adds required front matter metadata. |
| docs/planning/framework-upgrade-parallel-plan.md | Adds required front matter metadata and updates Gate 4 status narrative. |
| docs/planning/framework-quality-usability-plan.md | Adds a new Plan 3 document with front matter and detailed workstreams. |
| docs/planning/framework-optimization-follow-on-plan.md | Adds required front matter metadata and expands plan structure/dependencies. |
| docs/planning/external-acceptance-20260910.md | Adds a new external acceptance report with front matter and evidence references. |
| docs/packaging/verification.md | Adds required front matter metadata. |
| docs/packaging/README.md | Adds required front matter metadata. |
| docs/packaging/performance-audit.md | Adds required front matter metadata. |
| docs/packaging/documentation-project-integration.md | Adds required front matter metadata. |
| docs/packaging/coordination.md | Adds required front matter metadata. |
| docs/onboarding/readme.md | Adds required front matter metadata. |
| docs/LICENSE-INFO.md | Adds required front matter metadata and trims trailing whitespace. |
| docs/index.md | Adds required front matter metadata. |
| docs/filtering/query-contract.md | Adds required front matter metadata. |
| docs/filtering/filter-contract.md | Adds required front matter metadata. |
| docs/filtering/collection-operations.md | Adds required front matter metadata. |
| docs/best-practices/templates/readme.md | Adds required front matter metadata. |
| docs/best-practices/software-architecture/readme.md | Adds required front matter metadata. |
| docs/best-practices/security/readme.md | Adds required front matter metadata. |
| docs/best-practices/readme.md | Adds required front matter metadata. |
| docs/best-practices/radar.md | Adds required front matter metadata. |
| docs/best-practices/observability/readme.md | Adds required front matter metadata. |
| docs/best-practices/integration/readme.md | Adds required front matter metadata. |
| docs/best-practices/devops/readme.md | Adds required front matter metadata. |
| docs/best-practices/data-analytics/readme.md | Adds required front matter metadata. |
| docs/best-practices/cloud-architecture/readme.md | Adds required front matter metadata. |
| docs/architecture/verified-package-review.md | Adds required front matter metadata. |
| docs/architecture/package-boundaries.md | Adds required front matter metadata. |
| .github/repo-standards.md | Adds required front matter metadata. |
| .github/readme.md | Adds required front matter metadata (with BOM handling). |
| .github/ISSUE-TEMPLATE/radar-change-proposal.md | Adds required front matter metadata fields to the issue template header. |
| .github/instructions/web.instructions.md | Adds required front matter metadata fields. |
| .github/instructions/utilities.instructions.md | Adds required front matter metadata fields. |
| .github/instructions/testing.instructions.md | Adds required front matter metadata fields. |
| .github/instructions/sql.instructions.md | Adds required front matter metadata fields. |
| .github/instructions/python.instructions.md | Adds required front matter metadata fields. |
| .github/instructions/powershell.instructions.md | Adds required front matter metadata fields. |
| .github/instructions/playwright.instructions.md | Adds required front matter metadata fields. |
| .github/instructions/orleans.instructions.md | Adds required front matter metadata fields. |
| .github/instructions/notebooks.instructions.md | Adds required front matter metadata fields. |
| .github/instructions/mlnet.instructions.md | Adds required front matter metadata fields. |
| .github/instructions/javascript.instructions.md | Adds required front matter metadata fields. |
| .github/instructions/integration.instructions.md | Adds required front matter metadata fields. |
| .github/instructions/html.instructions.md | Adds required front matter metadata fields. |
| .github/instructions/graphql.instructions.md | Adds required front matter metadata fields. |
| .github/instructions/git.instructions.md | Adds required front matter metadata fields. |
| .github/instructions/docker.instructions.md | Adds required front matter metadata fields. |
| .github/instructions/design-patterns.instructions.md | Adds required front matter metadata fields. |
| .github/instructions/database.instructions.md | Adds required front matter metadata fields. |
| .github/instructions/csharp.instructions.md | Adds required front matter metadata fields. |
| .github/instructions/copilot-instructions.md | Adds required front matter metadata fields. |
| .github/instructions/cmd.instructions.md | Adds required front matter metadata fields. |
| .github/instructions/bash.instructions.md | Adds required front matter metadata fields. |
| .github/instructions/aspire.instructions.md | Adds required front matter metadata fields. |
| .github/instructions/angular.instructions.md | Adds required front matter metadata fields. |
| .github/instructions/algorithms.instructions.md | Adds required front matter metadata fields. |
| .github/CSHARP-STANDARDS.md | Changes doc_type to an allowed value for front matter validation. |
Review details
- Files reviewed: 89/89 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+41
to
+45
| <Folder Name="/.github/"> | ||
| <File Path=".github/CSHARP-STANDARDS.md" /> | ||
| <File Path=".github/repo-standards.md" /> | ||
| <File Path=".github/skills-index.md" /> | ||
| </Folder> |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: visionarycoder <8689814+visionarycoder@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.