Repository navigation
Fix VBD Analysis workflow root npm package resolution - #8
Conversation
Co-authored-by: visionarycoder <8689814+visionarycoder@users.noreply.github.com>
Co-authored-by: visionarycoder <8689814+visionarycoder@users.noreply.github.com>
Co-authored-by: visionarycoder <8689814+visionarycoder@users.noreply.github.com>
Co-authored-by: visionarycoder <8689814+visionarycoder@users.noreply.github.com>
Co-authored-by: visionarycoder <8689814+visionarycoder@users.noreply.github.com>
Co-authored-by: visionarycoder <8689814+visionarycoder@users.noreply.github.com>
Co-authored-by: visionarycoder <8689814+visionarycoder@users.noreply.github.com>
Co-authored-by: visionarycoder <8689814+visionarycoder@users.noreply.github.com>
Co-authored-by: visionarycoder <8689814+visionarycoder@users.noreply.github.com>
Co-authored-by: visionarycoder <8689814+visionarycoder@users.noreply.github.com>
Co-authored-by: visionarycoder <8689814+visionarycoder@users.noreply.github.com>
|
@copilot resolve the merge conflicts in this pull request |
|
@copilot resolve the merge conflicts in this pull request |
…tions-job-102940536472 # Conflicts: # .github/workflows/vbd-analysis.yml Co-authored-by: visionarycoder <8689814+visionarycoder@users.noreply.github.com>
Resolved the merge conflict and committed the merge as |
Already resolved in |
There was a problem hiding this comment.
🟢 Approval recommended
The workflow changes correctly gate all npm steps on a valid root package.json plus package-lock.json and improve failure clarity without introducing inconsistent conditions.
Pull request overview
Updates the VBD Analysis Validation GitHub Actions workflow to reliably run Node-based VBD/frontmatter/solution checks only when a valid repository-root Node package (with required scripts and lockfile) is present.
Changes:
- Adds
package-lock.jsonto the workflow path filters so lockfile changes trigger validation. - Detects and validates the repository-root
package.json(valid JSON + required scripts) and fails with explicit messages when invalid/misconfigured. - Requires a root
package-lock.json, runsnpm ci, and executes allnpm runvalidations from the detected package directory viaworking-directory.
File summaries
| File | Description |
|---|---|
| .github/workflows/vbd-analysis.yml | Adds root package/lockfile detection and deterministic npm execution gating for all Node-based validation steps. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The
VBD Analysis Validationworkflow was invokingnpm runfrom the repository root even when no rootpackage.jsonexisted, causingnpm ENOENTin job102940536472. This change makes the workflow explicitly validate and use the repository-level Node package context instead of assuming it.Workflow scope
.github/workflows/vbd-analysis.ymlon this branch.Root package detection
package.json.Deterministic npm execution
package-lock.jsonbefore running Node-based validation.npm ciand allnpm runsteps from the detected package directory viaworking-directory.Consistent script gating
vbd:artifacts:testfrontmatter:testsolution:markdown:testvbd:analysis:validatefrontmatter:validatesolution:markdown:checkFailure clarity
package.json