feat(frameworks): report every detected technology#314
Open
TBX3D wants to merge 1 commit into
Open
Conversation
framework detection collapsed to a single argmax winner, so a page built from several technologies (react behind a next.js server, say) reported only one and dropped the rest. add DetectFrameworks, which keeps every detector hit above the threshold ranked most-confident first, and wire the -framework path to emit one finding per detected framework. the single-winner DetectFramework stays for callers that want just the top match; both share one fetch through the new gatherDetections helper, so the extra coverage costs no additional request.
github-actions
Bot
added
scan
pr summary3 files changed (+173 -41)
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
=======================================
Coverage ? 54.86%
=======================================
Files ? 81
Lines ? 6911
Branches ? 0
=======================================
Hits ? 3792
Misses ? 2846
Partials ? 273 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
framework detection collapsed to a single argmax winner, so a page built from several technologies (react behind a next.js server, say) reported only one and dropped the rest.
adds
DetectFrameworks, which keeps every detector hit above the threshold ranked most-confident first, and wires the-frameworkpath to emit one finding per detected framework. the single-winnerDetectFrameworkstays for callers that want just the top match; both share one fetch through a newgatherDetectionshelper, so the extra coverage costs no additional request.verified live against a local server carrying both next.js and express markers:
-frameworknow reports bothNext.jsandExpress.jswhere it previously reported one. new tests cover the multi-report ordering and the no-match case; the existing single-detection tests are unchanged.