fix(report): sort sarif rules for reproducible output#329
Closed
TBX3D wants to merge 1 commit into
Closed
Conversation
the rules list was built by iterating a set, so the same scan produced sarif with the rules in a different order on every run, defeating diffing, caching and snapshot tests. sort the ids before emitting them.
pr summary2 files changed (+49 -3)
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #329 +/- ##
=======================================
Coverage ? 54.75%
=======================================
Files ? 81
Lines ? 6878
Branches ? 0
=======================================
Hits ? 3766
Misses ? 2843
Partials ? 269 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
closing as a duplicate of #337, which applies the identical sarif rule-id sort fix and also covers the markdown crlf fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the rules list was built by iterating a set, so the same scan produced
sarif with the rules in a different order on every run, defeating diffing,
caching and snapshot tests. sort the ids before emitting them.