Skip to content

feat(skill): add metrics and span attributes for skill download/load events - #1175

Open
mrcaidev wants to merge 3 commits into
volcengine:mainfrom
mrcaidev:feat/skill-o11y
Open

mrcaidev wants to merge 3 commits into
volcengine:mainfrom
mrcaidev:feat/skill-o11y

Conversation

@mrcaidev

@mrcaidev mrcaidev commented Oct 19, 2026 •

Copy link
Copy Markdown

给 VeSkillRegistry 的技能下载/加载事件添加可观测上报。

一些实现要点:

  • 通过 ADK Skill 的 frontmatter.metadata 传递火山技能元数据。
  • 添加了两个 counter:skill_download、skill_load,同时记录技能的来源、ID、版本、空间。
  • 添加了额外的 span 属性:consumer="runtime"、cache_hit 等。

@mrcaidev
mrcaidev marked this pull request as ready for review October 19, 2026 11:18
Copilot AI balanced review requested due to automatic review settings October 19, 2026 11:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@mrcaidev
mrcaidev requested a balanced review from Copilot October 19, 2026 11:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@mrcaidev mrcaidev changed the title feat: add metrics and span attributes for skill download/load events feat(skill): add metrics and span attributes for skill download/load events Oct 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants