Repository navigation
chore: unblock Renovate's Biome and lock refresh updates - #145
Merged
Merged
Conversation
The lock refresh in #79 failed CI: it moved Biome from 2.5.15 to 2.6.2, within ^2.5.15, but biome.json's $schema pinned the 2.5.15 URL and Biome refuses to run when the two differ. Any automatic Biome update hit the same wall. - biome.json takes its schema from the installed package, so Biome and its schema always match. Biome is now ^2.6.2. - Biome 2.6 also formats Markdown and YAML, which would reformat every doc and workflow (padding Markdown tables, for one). Exclude both, as 2.5 did; it checks the same 168 files. Adopting either formatter can be its own change. - 2.6's new usePlaywrightValidDescribeCallback rule flagged a helper named describe() in scripts/dependency-snapshot.ts, which is not a Playwright file. Rename it describeResult(). Renovate: - Lock file maintenance now automerges, gated by the required checks. Its stability check could never pass for Bun, so minimumReleaseAge is off for that update type; bunfig.toml enforces the same 7-day wait while Bun regenerates bun.lock. - Keep the postcss-selector-parser override on 6.x. Renovate was about to propose 7, a major @tailwindcss/typography has not adopted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Will Manning <will@willmanning.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🔦 Lighthouse audit
Run |
lwwmanning
temporarily deployed
to
bench-preview
October 30, 2026 01:42 — with
GitHub Actions
Inactive
|
Bench preview for |
lwwmanning
added a commit
that referenced
this pull request
Oct 30, 2026
Resolve the conflicts with #145 by keeping both sides: main's two new Renovate rules beside this branch's @types/node description, and this branch's Node paragraph beside main's longer auto-merge item. bench's functions still run on Node 24 until its project moves to 26.x, so its @types/node goes back to ^24.19.2, and a Renovate rule holds it below 25 until then, so bench code can't type-check against a Node 26 API its runtime lacks. The site stays on ^26. CLAUDE.md lists both steps for the switch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Will Manning <will@willmanning.io>
lwwmanning
added a commit
that referenced
this pull request
Oct 30, 2026
main moves Biome to 2.6 (#145), hardens /api/subscribe (#141), and refreshes the lockfile (#79), among bench fixes. - biome.json keeps this branch's generated stylesheets out of Biome and takes main's new Markdown and YAML exclusions. - Biome 2.6's noComponentHookFactories rejects the icon factories in the site's and bench's icons.tsx, so each icon is now a plain component around one MaterialSymbol. - CLAUDE.md and renovate.json drop main's postcss-selector-parser entries. This branch has no @tailwindcss/typography, so nothing depends on it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Will Manning <will@willmanning.io>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lock refresh in #79 failed CI. It moved Biome from 2.5.15 to 2.6.2, and
biome.jsonpinned its schema URL to 2.5.15, so Biome refused to run.biome.jsonnow reads the schema from the installed package, so any Biome version passes this check. Biome is now^2.6.2. Biome 2.6 also formats Markdown and YAML, so both are excluded, as before. It checks the same 168 files. A false positive from a new Playwright rule is fixed by renaming one helper.Renovate now automerges lock refreshes.
bunfig.tomlenforces the 7-day wait, because Renovate cannot do so for Bun. Renovate also keeps the postcss-selector-parser override on 6.x.🤖 Generated with Claude Code