Add UnionArray#8834
Conversation
Merging this PR will regress 1 benchmark
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c5b0a79a5f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Polar Signals Profiling ResultsLatest Run
Previous Runs (13)
Powered by Polar Signals Cloud |
Benchmarks: Vortex queries 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.012x ➖, 0↑ 0↓)
datafusion / parquet (0.968x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.986x ➖, 0↑ 0↓)
duckdb / parquet (1.001x ➖, 0↑ 0↓)
No file size changes detected. |
c5b0a79 to
c33685a
Compare
42124e3 to
df88950
Compare
c33685a to
9238470
Compare
df88950 to
c812c67
Compare
9238470 to
e2186b0
Compare
c812c67 to
dd92c91
Compare
dd92c91 to
fd2e580
Compare
e2186b0 to
cfa9d17
Compare
cfa9d17 to
66e354f
Compare
fd2e580 to
5e0113d
Compare
9e8367e to
3feabed
Compare
9c9debf to
dd86118
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
dd86118 to
772b738
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Rationale for this change
Tracking issue: #8769
This is the array layer of the Union stack. The compute integration has been split into the stacked follow-up #8884.
What changes are included in this PR?
UnionArrayencoding with nullable u8 type IDs and row-aligned children.I think that this is a mostly straightforward implementation. The one implementation thing I will shout out is that we do not validate that the entire type IDs array has valid type IDs. If we come across an invalid type ID, we just panic, and that is similar behavior to
DictArrayvalidation.What APIs are changed? Are there any user-facing changes?
Adds the public Union, UnionArray, UnionArrayExt, and UnionDataParts APIs.