test: guard HUD click-through surface - #859
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe PR adds a Vitest file that parses ChangesHUD pointer surface tests
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This test-only change adds focused coverage for the HUD click-through behavior without changing runtime behavior; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Adds a focused regression test for the floating recording HUD's pointer surface. The test parses
LaunchWindow.tsxand verifies that:Motivation
This protects the fix for the dead click zone reported in #698. The failure occurred when the interactive pointer surface stayed at the HUD's original bottom-screen position while the visible pill was translated elsewhere.
The production-side fix is already present on
main; this PR adds the missing regression coverage so that layout refactors cannot silently restore the invisible click-blocking region.Type of Change
Related Issue(s)
Related to #698.
Screenshots / Video
Not applicable; this is a test-only change.
Manual macOS verification was also performed: the issue was reproduced on v1.3.3, then an app containing the current click-through fixes was tested successfully. After moving the HUD, the original bottom-screen area accepted clicks normally.
Testing Guide
npm test— 118 test files, 1,054 tests passednpm exec tsc -- --noEmitnpm exec tsc -- --noEmit --strict --target ES2020 --module ESNext --moduleResolution bundler --skipLibCheck src/components/launch/hudPointerSurface.test.tsnpx biome check src/components/launch/hudPointerSurface.test.tsCSC_IDENTITY_AUTO_DISCOVERY=false npm run buildChecklist
Summary by CodeRabbit