Skip to content

test: guard HUD click-through surface - #859

Open
ILikeAI wants to merge 1 commit into
webadderallorg:mainfrom
ILikeAI:codex/hud-clickthrough-regression
Open

test: guard HUD click-through surface#859
ILikeAI wants to merge 1 commit into
webadderallorg:mainfrom
ILikeAI:codex/hud-clickthrough-regression

Conversation

@ILikeAI

@ILikeAI ILikeAI commented Sep 2, 2026

Copy link
Copy Markdown

Description

Adds a focused regression test for the floating recording HUD's pointer surface. The test parses LaunchWindow.tsx and verifies that:

  • the stationary layout wrapper remains click-through after the HUD is moved
  • only the visibly transformed HUD bar is interactive
  • the hover handlers stay on that visible bar

Motivation

This protects the fix for the dead click zone reported in #698. The failure occurred when the interactive pointer surface stayed at the HUD's original bottom-screen position while the visible pill was translated elsewhere.

The production-side fix is already present on main; this PR adds the missing regression coverage so that layout refactors cannot silently restore the invisible click-blocking region.

Type of Change

  • New Feature
  • Bug Fix
  • Refactor / Code Cleanup
  • Documentation Update
  • Other: regression test

Related Issue(s)

Related to #698.

Screenshots / Video

Not applicable; this is a test-only change.

Manual macOS verification was also performed: the issue was reproduced on v1.3.3, then an app containing the current click-through fixes was tested successfully. After moving the HUD, the original bottom-screen area accepted clicks normally.

Testing Guide

  • npm test — 118 test files, 1,054 tests passed
  • npm exec tsc -- --noEmit
  • npm exec tsc -- --noEmit --strict --target ES2020 --module ESNext --moduleResolution bundler --skipLibCheck src/components/launch/hudPointerSurface.test.ts
  • npx biome check src/components/launch/hudPointerSurface.test.ts
  • CSC_IDENTITY_AUTO_DISCOVERY=false npm run build

Checklist

  • I have performed a self-review of my code.
  • I have added regression coverage for the reported behavior.
  • I have linked the related issue.
  • No changelog update is needed for this test-only PR.

Summary by CodeRabbit

  • Tests
    • Added coverage to verify correct pointer interaction behavior for the launch HUD.
    • Confirmed stationary layout elements remain non-interactive while the transformed HUD bar supports hover interactions.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: e0c2d1c5-1243-4240-b201-48a7fb3104bd

📥 Commits

Reviewing files that changed from the base of the PR and between fdded88 and 02cf213.

📒 Files selected for processing (1)
  • src/components/launch/hudPointerSurface.test.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The PR adds a Vitest file that parses LaunchWindow.tsx and validates pointer-event classes and hover handlers on the HUD layout wrapper and transformed HUD bar.

Changes

HUD pointer surface tests

Layer / File(s) Summary
Pointer surface source assertions
src/components/launch/hudPointerSurface.test.ts
Parses the TSX source and locates JSX elements by ref. Tests verify that the layout wrapper uses pointer-events-none without hover handlers, while the HUD bar uses pointer-events-auto with onMouseEnter and onMouseLeave.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 02cf2

This test-only change adds focused coverage for the HUD click-through behavior without changing runtime behavior; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: regression coverage for the HUD click-through surface.
Description check ✅ Passed The description covers the purpose, motivation, change type, related issue, testing, manual verification, and checklist. It correctly explains that the PR adds regression coverage only.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant