Fix invisible update notifications on Windows and Linux - #869
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe update flow uses native dialogs for non-macOS previews and fallback notifications. macOS continues to use update toasts. The main process routes preview requests by platform, and updater errors display a native dialog when renderer toast delivery fails. ChangesUpdate dialog flow
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to Windows and Linux update notifications now use native dialogs while macOS retains custom toasts. The available evidence indicates the intended install, reminder, preview, and fallback behavior is preserved, with no current merge-blocking risk identified. Sequence Diagram(s)sequenceDiagram
participant PreviewRequest
participant MainProcess
participant Updater
participant Renderer
participant NativeDialog
PreviewRequest->>MainProcess: request update preview
alt macOS
MainProcess->>Renderer: show update toast preview
else non-macOS
MainProcess->>Updater: preview native update dialog
Updater->>NativeDialog: show available-update preview
end
Updater->>Renderer: emit update state
alt Renderer does not show toast
Updater->>NativeDialog: show fallback update dialog
end
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the problem, the platform-specific behavior, the user-facing impact, and the testing performed. It does not use the repository template headings and omits the change type, related issues, screenshots or video, and checklist.
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Motivation and Context
The custom Chromium update-toast window can render as a blank black surface on Windows and is compositor-dependent on Linux, even though its renderer bitmap contains the complete UI. Because update downloads require user confirmation, this can make the normal update path unusable.
What changed
Testing
Summary by CodeRabbit
New Features
Bug Fixes