fix: restore Ask-streaming copy in 10 locales after mojibake - #2951
Merged
esokullu merged 1 commit intoAug 29, 2026
Merged
Conversation
'st.display.openai_ask_streaming.label'/'.desc' have shipped as literal runs of '?' (e.g. "? Ask ????????") since commit e9643a6 ("Add 76 LLM providers and Ask streaming") in ar, bn, fa, he, hi, ja, ko, ru, th, uk — in both the chrome and firefox locale directories (20 files, 40 lines). PR webbrain-one#2949 restored only zh; this restores the remaining 10 locales with native-quality copy via an idempotent replace-in-place pass added to scripts/i18n-perm-translations.mjs. Also generalize the PR webbrain-one#2949 mojibake regression guard from zh-only to every locale in test/run.js, so a recurrence of '?'-run corruption fails the build.
|
@esokullu is attempting to deploy a commit to the esokullu's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2950
Summary
Restores the garbled
st.display.openai_ask_streaming.label/.descsettingscopy in the 10 locales that still ship it as literal runs of
?(e.g."? Ask ????????"/"???????????????? Ask"):ar,bn,fa,he,hi,ja,ko,ru,th,uksrc/chrome/src/ui/locales/andsrc/firefox/src/ui/locales/(20 files, 40 lines)PR #2949 fixed only the Chinese (
zh.js) locale for this exact key; this PRfixes the remaining ten with native-quality copy.
Where the corruption came from
All 20 files had intact native translations until commit
e9643a67f— "Add 76 LLM providers and Ask streaming", by Barack Sokullu(2026-07-23 17:12:06 +0300). That commit re-translated these two keys for the
"Ask" rename and committed them as
?-runs (verified viagit log -Lon eachfile: every one of the 20 files shows
INTACT → CHANGED IN e9643a67f). Thegarble has shipped in every release since, including the committed
dist/webbrain-*-33.6.0.zipsubmission packages.Implementation
scripts/i18n-perm-translations.mjs— adds a second, idempotent,replace-in-place pass for the Ask-streaming keys. It only rewrites a value
when the stored value contains
?(never clobbers intact translations), andskips locales without entries. Also adds table entries for the previously
missing
bn,fa,he,hiand hardens the pass-1 insert guard to bequote-agnostic (he.js uses double-quoted keys).
no-ops once fixed).
test/run.js— generalizes the PR fix: restore Chinese Ask streaming copy #2949 zh-only mojibake regressionguard to every locale (both builds): the
st.display.openai_ask_streaming.label/.desckeys must not contain a?-run, so a recurrence fails the build.Testing
node test/run.js→ 2110 passed, 0 failed?{4,}matches remainFollow-up (out of scope)
es.js,fr.js,pl.js,pt.js,vi.jsshow a subtler single-?accentloss (e.g.
"transmisi?n","r?ponses") for this same key — a differentwhole-file Latin-encoding corruption that affects many other keys in those
files. Worth a separate issue/PR.