Add SPRING support to image queries and downloads - #68
Merged
Merged
Conversation
winterwebapi's image endpoints now take an instrument=winter|spring query parameter instead of separate /images/spring/... routes; the /too/winter and /too/spring routes are unchanged (both already accept any ToO type via wintertoo's AllTooClasses union, so ToO submission needed no client-side changes). Added instrument: Literal["winter", "spring"] = "winter" to query_images, its four query_images_by_* wrappers, and download_image_list, threaded straight through as a request query param. Every default is "winter", so all existing callers (including the example notebooks and tests/test_schedule.py) are unaffected. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
robertdstein
enabled auto-merge (squash)
September 10, 2026 01:35
robertdstein
disabled auto-merge
September 10, 2026 01:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
winterwebapirecently added SPRING image support:/images/query,/images/download_query, and/images/download_listnow take aninstrument: Literal["winter","spring"] = "winter"query parameter (no more separate/images/spring/...prefix)./too/winter,/too/spring) is unchanged server-side — both routes already accept any ToO type viawintertoo'sAllTooClassesunion — sosubmit_too/submit_too_spring/submit_too_summerneeded no changes here.instrument: Literal["winter", "spring"] = "winter"toquery_images, its fourquery_images_by_*wrappers, anddownload_image_list, threaded straight through as a request query param. Every default is"winter", so all existing callers are unaffected.pyproject.tomlversion bump (1.6.0 → 1.7.0) to matchwinterwebapi's v1.7 release. Local notebook diffs (stale execution-output churn — server URL, email, Python version from local runs) are intentionally excluded from this PR.Test plan
black/isortclean onwinterapi/messenger.py.query_images, the fourquery_images_by_*wrappers,download_image_list) exposeinstrument: Literal["winter","spring"] = "winter".requests.get, no network) thatinstrument="spring"is correctly sent as a query parameter in the outgoing request.winterwebapibefore merge.🤖 Generated with Claude Code