Repository navigation
Conversation
4 tasks
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified for the change restoring unsalted EVP_BytesToKey compatibility.
No open issues 🎉
What changed in this PR
Restores unsalted EVP_BytesToKey compatibility after #12059 tightened wc_PBKDF1_ex argument validation, addressing the reported wolfCLU failures.
Changes:
- Passes a zero salt length when the salt pointer is
NULL, preserving the eight-byte length for present salts. - Adds an AES-128-CBC/SHA-256 regression case that checks the derived key and IV without salt.
| File | Description |
|---|---|
wolfcrypt/src/evp.c |
Makes the KDF salt length match salt presence. |
tests/api/test_evp_cipher.c |
Adds expected key and IV assertions for unsalted derivation. |
Review effort: Balanced
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Account for the tightening of args in #12059.
This PR fixes general openssl compat for 0 salt encrypt's. Observed through wolfCLU failures.
Testing
./configure --enable-wolfclu && make & make installin wolfSSL./configure && make checkin wolfcluChecklist