Repository navigation
Make the run time report work again - #399
Merged
Merged
Conversation
Scenario nodes no longer expose their feature file, so per-scenario run times and the scenario part of run directory names were empty. Take the file from the feature instead. The report is written from an after-suite hook, whose output Behat only prints for failed scenarios. Write it to the output stream directly so it shows up with the default progress formatter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
github-actions
Bot
added
bug
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the first two steps of #384.
With
WP_CLI_TEST_LOG_RUN_TIMESset, the report printed at the end of a run was invisible with the default progress formatter, and its per-scenario part was always empty ("Top 20 (of 0) scenario run times"). The scenario part ofRUN_DIRnames was missing for the same reason.Now the report shows up in every run and lists the slowest scenarios, which is the data needed to compare the other changes in #394 and to balance parallel runs later.
A new scenario checks that run directories are named after their scenario again.