Skip to content

Fix invalid probe handlers in gateway runtime deployment - #3069

Merged
renuka-fernando merged 1 commit into
wso2:mainfrom
O-sura:health-check-conformance-fix
Aug 3, 2026
Merged

Fix invalid probe handlers in gateway runtime deployment#3069
renuka-fernando merged 1 commit into
wso2:mainfrom
O-sura:health-check-conformance-fix

Conversation

@O-sura

@O-sura O-sura commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Purpose

$subject

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@O-sura, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 55 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7d0c57e1-4674-48f0-a814-dda4accd3f48

📥 Commits

Reviewing files that changed from the base of the PR and between d84a6ef and 1ab0e8e.

📒 Files selected for processing (2)
  • kubernetes/gateway-operator/internal/helm/gateway_runtime_probe_render_test.go
  • kubernetes/helm/operator-helm-chart/values.yaml
📝 Walkthrough

Walkthrough

Changes

Gateway probe validation

Layer / File(s) Summary
HTTPS gateway probe configuration
kubernetes/helm/operator-helm-chart/values.yaml
Gateway liveness and readiness probes now use HTTPS health endpoints on the https port.
Operator values rendering and probe validation
kubernetes/gateway-operator/internal/helm/gateway_runtime_probe_render_test.go
Reusable rendering and deployment helpers support operator chart values. A regression test verifies that configured probes use exactly one Kubernetes handler.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested reviewers: thushani-jayasekera

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description contains only a placeholder under Purpose and omits the required goals, approach, tests, security, documentation, and environment details. Complete the template with the purpose, goals, approach, user stories, documentation impact, test results, security checks, samples, related PRs, and test environment.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the fix to invalid probe handlers in the gateway runtime deployment.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@O-sura
O-sura force-pushed the health-check-conformance-fix branch from d84a6ef to 550d2a3 Compare August 3, 2026 06:00
@O-sura
O-sura force-pushed the health-check-conformance-fix branch from 550d2a3 to 1ab0e8e Compare August 3, 2026 06:03
@renuka-fernando
renuka-fernando merged commit 4232b66 into wso2:main Aug 3, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants