Skip to content

WVDSH-1650: add --no-open flag to wavedash dev#40

Merged
franzwarning merged 1 commit into
mainfrom
franzwarning/wvdsh-1650-add-a-flag-to-not-open-browser-with-wavedash-dev
Jun 29, 2026
Merged

WVDSH-1650: add --no-open flag to wavedash dev#40
franzwarning merged 1 commit into
mainfrom
franzwarning/wvdsh-1650-add-a-flag-to-not-open-browser-with-wavedash-dev

Conversation

@franzwarning

Copy link
Copy Markdown
Member

Adds a --no-open flag to wavedash dev that skips automatically opening the browser and instead prints the local URL for the user to open manually. The dev server still runs normally.

  • New no_open: bool arg on the Dev command, threaded into handle_dev.
  • Branches around the open::that(&local_url)? call.
  • Bumps version 0.1.87 → 0.1.88.

Tested end-to-end against a live build: with --no-open the server comes up and prints the URL without opening a browser; default behavior still opens the browser and runs the full auth flow.

🤖 Generated with Claude Code

Add a --no-open flag to 'wavedash dev' that skips automatically opening
the browser and instead prints the local URL for the user to open
manually. Bump version to 0.1.88.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude

claude Bot commented Jun 29, 2026

Copy link
Copy Markdown

Claude finished @franzwarning's task in 1m 12s —— View job


Code Review: --no-open flag for wavedash dev

  • Read changed files & diff
  • Review implementation
  • Post review feedback

The change is small, focused, and correct. The flag is wired cleanly from the clap definition (src/main.rs:77-82) through the match arm (src/main.rs:438-439) into handle_dev (src/dev/mod.rs:57), and the branch around open::that (src/dev/mod.rs:181-185) is right. The dev server still starts regardless of the flag, which matches the intent. 👍

A few minor / optional observations — nothing blocking:

1. Bonus benefit worth noting (no change needed)
Previously open::that(&local_url)? would propagate an error and abort the whole command in environments where no browser can be launched (headless/CI/SSH). --no-open now gives users a clean escape hatch for exactly that case. Nice.

2. Slightly redundant URL output (src/dev/mod.rs:173 & :182)
Line 173 already prints the URL:

println!("wavedash dev → {}", local_url);   // :173
...
println!("  --no-open set; open {} in your browser to start.", local_url);  // :182

So with --no-open the URL is printed twice. Not wrong, and the second line adds the actionable instruction, so this is purely cosmetic — feel free to leave as-is.

3. Consistency with auth login (src/auth.rs:145)
handle_auth also calls open::that(&auth_url)? with no opt-out. If skipping browser auto-open is something users want for dev, they may want it for auth login too. Out of scope for this PR — just flagging for a potential follow-up so the UX stays consistent. Add a --no-open flag to the auth login command in src/auth.rs (line 145), mirroring the one added to wavedash dev — print the auth_url instead of calling open::that when set →

Note: I did not run cargo check/clippy (per CLAUDE.md these require doppler run --, which isn't available in this review environment), but the change is trivial and type-correct — all three call sites are updated consistently.

Overall: LGTM. ✅

@franzwarning franzwarning merged commit 3c45455 into main Jun 29, 2026
7 checks passed
@franzwarning franzwarning deleted the franzwarning/wvdsh-1650-add-a-flag-to-not-open-browser-with-wavedash-dev branch June 29, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant