Skip to content

fix: second audit findings (2026-11-12) - #14

Merged
franciscbalint merged 3 commits into
mainfrom
fix/audit2-2026-11-12
Nov 11, 2026
Merged

franciscbalint merged 3 commits into
mainfrom
fix/audit2-2026-11-12

Conversation

@franciscbalint

Copy link
Copy Markdown
Collaborator

Second re-audit (2026-11-12) fixes.

  • The streaming download now checks write errors, rejects a JSON object body whatever its content type, and deletes the partial file. Before, a JSON error body was saved as the file, and a write that hit a file-size limit still reported success.
  • All downloads reject a JSON object body instead of saving it.
  • gcc 15 -Wformat-overflow: the column buffer (int_str_option[10]) is now 16 bytes and filled with snprintf. Four warnings in a Release build on Ubuntu 26.04 are gone; an INT_MIN/INT_MAX test is added (it crashed the macOS fortify build before the fix).
  • Second commit: CodeQL uses a manual build with a config file; the Dockerfile moves to Ubuntu 26.04.

Tests 114+4 → 116+7 on macOS, Ubuntu 24.04 and 26.04, and the CMake 3.21.0 floor.

@franciscbalint
franciscbalint merged commit b44488f into main Nov 11, 2026
8 checks passed
@franciscbalint
franciscbalint deleted the fix/audit2-2026-11-12 branch November 11, 2026 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant