Skip to content

fix: audit findings (2026-11-11, round 4) - #15

Merged
franciscbalint merged 1 commit into
mainfrom
fix/audit4-2026-11-11
Nov 12, 2026
Merged

franciscbalint merged 1 commit into
mainfrom
fix/audit4-2026-11-11

Conversation

@franciscbalint

Copy link
Copy Markdown
Collaborator

Fourth audit (2026-11-11) fixes.

  • Medium: a Warmup CSV download that failed mid-write left the partial file; it is now deleted.
  • Medium: a failed streaming getfile deleted a file that was already at the target path (buffered get_file kept it). Streaming downloads now write to <path>.<pid>-<id>.part and rename into place only on success; a failure removes only the temp file. README and documentation.md describe this.
  • Tests: the non-2xx check on downloads, the transport-error check on JSON, sendfile, batch and multipart, and partial-file removal after a streaming transport error now have failing tests (audit mutations M26a–f, M35–M38).

117 + 11 tests (was 116 + 7) pass on macOS and Ubuntu 24.04, and on the CMake 3.21.0 floor.

@franciscbalint
franciscbalint merged commit 0effc45 into main Nov 12, 2026
8 checks passed
@franciscbalint
franciscbalint deleted the fix/audit4-2026-11-11 branch November 12, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant