Repository navigation
test: audit findings (2026-11-12, round 5) - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only fix from the fifth audit (Medium: the HTTPS sweep was a hand-written list).
test_offline_every_request_function_is_in_the_sweepreadsZeroBounce.h(path passed in asZB_PUBLIC_HEADERfor the test target), lists every non-static declaration taking anOnErrorCallback, and compares it with the functions the plain-http sweep actually ran, both ways. Droppingscore_email_postor the deprecatedfind_emailfrom the sweep, or declaring a new function, now fails it.Tests 117 → 118 (+ 11 transport tests) on macOS and ubuntu:24.04.