Repository navigation
Fix row stride for rectangular two-dimensional arrays - #61
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Array2D uses height instead of width as the row stride. A 4×2 array overwrites the end of its first row when filling the second; a 2×4 array panics for valid coordinates. Existing square-array tests mask this.
Use width consistently in Get/Set, Row/RowSpan and Fill. Add rectangular, single-row and single-column regression cases checking values, row slices, reversed spans, String, Copy, OfJagged and partial Fill. The original implementation reproduces both overwriting and an index-out-of-range panic.
Validation: full
go test -race ./...andgo vet ./...on Go 1.27.1, full tests on Go 1.19.13 (the CI series), Staticcheck 2026.2.1, formatting andgit diff --checkpass on Linux/arm64. The historical CI Staticcheck 2022.1.1 version was not run.AI-assisted implementation and validation.