Repository navigation
Release references in unused heap slots after Pop - #62
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Popping pointer values leaves references in the heap's unused backing-array slots, keeping objects alive even after the heap is empty. In a public-API reproduction that pushes 512 objects containing 64 KiB payloads, drains the heap, and forces GC while keeping the heap alive, retained HeapAlloc was 11,138,048 bytes before the fix and 5,008 bytes afterward on this machine.
Zero the vacated slot before shortening the slice. The regression uses the documented shared storage of FromSlice to verify released references deterministically, alongside pop ordering and reuse after draining. It fails before the change. The comparison above is an illustrative local allocation measurement, not a cross-platform benchmark.
Validation: full race tests, vet and Staticcheck 2026.2.1 on Go 1.27.1; full tests on CI's Go 1.19.13 series; formatting and diff checks pass. Historical Staticcheck 2022.1.1 was not run. AI-assisted implementation and validation.