Repository navigation
fix(set): correct IsDisjoint logic and optimize memory allocation - #64
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a logical bug in
IsDisjointand addresses theTODO: maybe optimize?comment.The Bug:
Previously,
IsDisjointreturnedtrueif the intersection size was> 0, which is the mathematical opposite of disjoint (sharing zero elements).The Optimization:
Instead of fixing it by changing the condition to
== 0, I rewrote the method usings.Each(). The previous implementation calleds.Intersection(other), which forced a full O(N) memory allocation to clone the set just to check for a single overlap. The new implementation checks for overlaps in-place, returning immediately with O(1) auxiliary space.Changes:
IsDisjointlogic to return true only if zero elements are shared.s.Each()for zero-allocation performance.ExampleSet_IsDisjointinset_test.goto verify both true and false disjoint conditions while matching the existing testing style.Testing:
go test ./set/...passes locally.go fmtapplied.Closes #63