Repository navigation
Conversation
Signed-off-by: Yusuf Efe <120668197+yuefdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OfJaggeddocuments that out-of-bounds input values are ignored, but extra rows currently reachRow(y)and panic. For example, a 2×2 array cannot be built from three source rows.Stop copying once the requested height is reached. Column truncation still uses
copy, and missing values stay zero-filled.The regression panics on the original code. It covers excess rows and columns, zero dimensions, and missing rows.
go test ./... -count=1andgo test -race ./... -count=1pass in all 20 packages; vet, gofmt and the diff check also pass. The race suite ran on Windows with Clang and cgo enabled.