Repository navigation
Fix texture flipping for hextiledimage and hextilednormalmap. - #3016
jreichel-nvidia wants to merge 2 commits into
Conversation
Add new mxp_flip_v parameter to forward the generator option for texture flipping.
|
This looks like a great improvement to me, @jreichel-nvidia, and I'd ideally like to merge #3001 before reviewing and merging this complementary work, so that we can leverage the new alignment between specification and codebase that it brings. |
|
@jstone-lucasfilm As suggested I've revisited this after #3001 has been merged. Before this MR (ebc8cc8), the GLSL/OSL and MDL test renderers produces different results. I thought this MR needed some more changes to accomodate for #3001, but could it be that GLSL/OSL is now wrong? (The following analysis was with some AI support, my apologies if I got it wrong.) AIUI hex tiling has two distinct steps:
Step 1 should produce the same results on every target. Only step 2 needs to account for different image origins. Let H represent hex tiling and F the V flip. With the current test settings: (MDL uses fileTextureVerticalFlip=false, that's why 'F' it is absent from the 1st row.) |
|
Converted back to draft to make it clear that I do not/no longer intend to merge the PR as it is. |
Add new mxp_flip_v parameter to forward the generator option for texture flipping.