fix(classifier): treat clean prs with stale queued check suites as ready

src/models/prItem.js

@@ -241,15 +241,14 @@ function areRequiredChecksPassing(rawNode) {
     }
 
     const { rollup, checkSuites, contexts, required } = getCheckData(rawNode);
-    if (!rollup || rollup.state === 'SUCCESS') {
-        if (!rollup && checkSuites.length > 0) {
-            return false;
-        }
+    // GitHub reports CLEAN when nothing blocks the merge. Check suites from apps that
+    // never report a result (e.g. Codecov) can stay QUEUED forever without a rollup.
+    if (rawNode.mergeStateStatus === 'CLEAN' || rawNode.mergeStateStatus === 'HAS_HOOKS') {
         return true;
     }
 
-    if (rawNode.mergeStateStatus === 'CLEAN' || rawNode.mergeStateStatus === 'HAS_HOOKS') {
-        return true;
+    if (!rollup || rollup.state === 'SUCCESS') {
+        return rollup !== null || checkSuites.length === 0;
     }
 
     // Every required check must have reported and passed

tests/testClassifier.js

@@ -325,6 +325,25 @@ function withChecks({ rollupState, contexts, required = null, mergeStateStatus,
     assertEqual(pr.reasons, ['Approved'], 'Reason is Approved');
 }
 
+// 4l. Null rollup with check suites that never report, but GitHub says CLEAN
+{
+    const pr = new PRItem(makePR({
+        reviewDecision: 'APPROVED',
+        statusCheckRollup: null,
+        mergeStateStatus: 'CLEAN',
+        commits: {
+            nodes: [{
+                commit: {
+                    checkSuites: {
+                        nodes: [checkSuite(null, 'QUEUED'), checkSuite(null, 'QUEUED')],
+                    },
+                },
+            }],
+        },
+    }), viewerLogin);
+    assertEqual(pr.category, CATEGORIES.READY_TO_MERGE, 'CLEAN PR with stale queued check suites is READY_TO_MERGE');
+}
+
 // 5. Action Required: Merge Conflicts
 {
     const pr = new PRItem(makePR({ mergeable: 'CONFLICTING' }), viewerLogin);