Repository navigation
Conversation
Also rename test class to GenericTestGitRepository for clarity
create_git_repository_instance now defaults to GenericGitRepository, logging the given git_host if the default is used.
Collaborator
Author
|
Closing this in favor of a larger PR implementing GitLab support for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the work done to make
submit_job()support GitLab was adding a newGitRepositoryclass,GenericGitRepository, and rewritingclone_git_repo()to use it. The new class is intended for simple, (presumably) host-agnostic Git operations like cloning. I also changedcreate_git_repository_instance()to fall back to creating aGenericGitRepositoryinstance for an unknowngit_hostinstead of returningNone.I have tested the new
submit_job()on both GitHub and GitLab by configuring the bot to use this simple script hosted on Codeberg (build_job_script = test.sh@https://codeberg.org/sondrebr/test-sbatch) to verify that the newclone_git_repo()implementation still works with an arbitrary Git hosting platform. I of course also tested thatsubmit_job()still works with a localbuild_job_script.As a side note, the functionality of retrieving the build job script from a separate Git repository seems to be undocumented; I made an issue for it (#401).