Skip to content

Add GitLab support for submit_job() - #402

Closed
sondrebr wants to merge 4 commits into
EESSI:developfrom
sondrebr:add-gitlab-support-submit-job
Closed

sondrebr wants to merge 4 commits into
EESSI:developfrom
sondrebr:add-gitlab-support-submit-job

Conversation

@sondrebr

Copy link
Copy Markdown
Collaborator

Most of the work done to make submit_job() support GitLab was adding a new GitRepository class, GenericGitRepository, and rewriting clone_git_repo() to use it. The new class is intended for simple, (presumably) host-agnostic Git operations like cloning. I also changed create_git_repository_instance() to fall back to creating a GenericGitRepository instance for an unknown git_host instead of returning None.

I have tested the new submit_job() on both GitHub and GitLab by configuring the bot to use this simple script hosted on Codeberg (build_job_script = test.sh@https://codeberg.org/sondrebr/test-sbatch) to verify that the new clone_git_repo() implementation still works with an arbitrary Git hosting platform. I of course also tested that submit_job() still works with a local build_job_script.

As a side note, the functionality of retrieving the build job script from a separate Git repository seems to be undocumented; I made an issue for it (#401).

Also rename test class to GenericTestGitRepository for clarity
create_git_repository_instance now defaults to GenericGitRepository,
logging the given git_host if the default is used.
@sondrebr

sondrebr commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator Author

Closing this in favor of a larger PR implementing GitLab support for the bot: build command, #403.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant