Skip to content

Add GitLab support for bot: build command - #403

Open
sondrebr wants to merge 10 commits into
EESSI:developfrom
sondrebr:add-gitlab-support-bot-build-command
Open

sondrebr wants to merge 10 commits into
EESSI:developfrom
sondrebr:add-gitlab-support-bot-build-command

Conversation

@sondrebr

Copy link
Copy Markdown
Collaborator

Adds the changes in PRs #400 and #402 (refer to those for more details), in addition to adding GitLab support for create_pr_comment(), submit_build_jobs() and, finally (!), the bot: build command.

In create_pr_comment(), the pr parameter has been replaced with event_info, and the app_name parameter has been removed by making the function itself retrieve the app name. Additionally, its tests have been updated to match the new signature. Note that no new tests have been added for GitLab; the function itself does not depend on the configured Git hosting platform, only some of the functions it calls.

In submit_build_jobs(), the pr parameter has been removed with event_info being used instead, and references to GitHub have been removed.

Lastly, handle_bot_command_build() has been updated to use the EventInfo properties, making it support GitLab. The GitLab supported commands list in commands.py has been updated to enable bot: build on GitLab, and the README has been updated to reflect this.

Note that the event handler can now create a comment on the PR when the job is submitted, but the job manager cannot yet update it.

@sondrebr sondrebr added the gitlab related to GitLab support label Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gitlab related to GitLab support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant