Repository navigation
Refused test runs while the test environment is being set up - #764
Merged
Merged
Conversation
`settings.get("_env", {})` only falls back to `{}` when the key is missing, so
a stored `"_env": null` (as `msgspec.to_builtins` writes for a tester whose
environment has not been created yet) made `**env` raise TypeError. Treat
null the same as a missing key.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A test run queued before a settings update could read the new settings while `update_test_settings` was still building the environment. The client already refuses new runs in this state; the server now refuses queued ones as well. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
david-yz-liu
changed the title
`_env` now defaults to `{}` in markus-autotesting-core
(MarkUsProject/markus-autotesting-core#14), so stored settings no longer
contain `"_env": null` and the fallback is unnecessary.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
david-yz-liu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The client's
run_testsrefuses new test runs while_env_statusis"setup"(503). But a test run queued before a settings update reads the settings only when it starts. By then the client may have replaced them with the new settings (_env_status: "setup"), andupdate_test_settingsmay still be building each tester's environment and replacing the test files.The server's
run_testrefused only settings with_erroror_env_status: "error", so the queued run went ahead in that half-built state: without the tester's_env(e.g. noPYTHON), and possibly while the test files were being replaced.run_testnow also refuses_env_status: "setup", with the same message the client uses: "Setting up test environment. Please try again later." Like the client, it doesn't refuse settings that have no_env_status.🤖 Generated with Claude Code