Skip to content

[https://nvbugs/7082290][infra] Waive 1 failed case(s) on CPU - #22128

Merged
xxi-nv merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:auto-waive/85005b6475a076b6e8d1d436c641ce9a
Nov 11, 2026
Merged

xxi-nv merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:auto-waive/85005b6475a076b6e8d1d436c641ce9a

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Temporarily waive 1 failed case(s) on CPU. Opened automatically by auto-waive (draft; a human reviews and merges).

The native main-break detector (native-p3/k3-w12h-fresh12h-nopass-hostclock/1.0.1) reports unittest/_torch/modeling_v2/test_modeling_v2_ci_selection.py::test_every_test_is_in_a_test_list broken on main for CPU: failure signature assertionerror: no test list runs: [unittest/_tor...ling_v#/minimax_m#/minimax_m#_nvfp#__sm_#__tp#], onset 2026-11-11T05:17:41Z, latest failure 2026-11-11T16:55:21Z. Policy native_p3@1.0.0 selected it; https://nvbugs/7082290 tracks the fix. Scope CPU is the stage prefix that ran the failing test.

  • Bug: https://nvbugs/7082290 (details, logs and 7-day test history are in the bug)
  • Restore coverage when: Remove this line when https://nvbugs/7082290 is fixed or closed and the test passes on CPU post-merge; un-waive follows the bug, not the PR.
  • Scope reviewed by: auto-waive at 2026-11-11T17:35:54.096150+00:00

Tests in this break event:

  • unittest/_torch/modeling_v2/test_modeling_v2_ci_selection.py::test_every_test_is_in_a_test_list on CPU

PRs whose pre-merge runs hit this break (rebase or re-run after this merges):

full:CPU/unittest/_torch/modeling_v2/test_modeling_v2_ci_selection.py::test_every_test_is_in_a_test_list SKIP (https://nvbugs/7082290)

What to check before merging:

  • The bug's test-history links show the cases failing on main, not only on the trigger PR.
  • The scope CPU matches the failing stage and no narrower waiver already exists.
  • Nothing else is needed from you after merging: the bug owner removes these lines with the fix.
Provenance
  • Detector native-p3/k3-w12h-fresh12h-nopass-hostclock/1.0.1, policy native_p3@1.0.0
  • Run 65046dd9-e2d6-4409-8729-c794309b7648; snapshot SHA-256 071b5b926f6e6f256e786b788b71ea3d79b8a5b369ca2c34ef617860cc25e1f9; config SHA-256 827822edec6c6c89190d7f337e057dad17ee187239b7172d2c79a29eb3de4227
  • unittest/_torch/modeling_v2/test_modeling_v2_ci_selection.py::test_every_test_is_in_a_test_list: incident c3db3e723e9b404b76ec009736075eba1e0a93d67becec475a587fc36a3d1b2a, observation 3ddf72498116a3d5c081c365d5cfad858313086c639dffeaa8f8a03185ca8f8e

Test Coverage

Review the incident evidence and selector scope before merging. This proposal does not
establish that main is fixed. Confirm restoration separately after the corrective change.

PR Checklist

  • Please check this after reviewing the above items as appropriate for this PR.

Dev Engineer Review

  • The diff adds one waiver line to tests/integration/test_lists/waives.txt. It changes no source code, configuration, or API.
  • The waiver skips unittest/_torch/modeling_v2/test_modeling_v2_ci_selection.py::test_every_test_is_in_a_test_list in the full:CPU stage only. Other stages still run the test.
  • The waiver hides a reported failure on main. The change does not fix the underlying break. The linked bug, NVBUG 7082290, tracks the fix.
  • Removal of the waiver depends on the bug closing and the test passing on CPU after merge. The description does not assign this follow-up to a specific owner or date.

QA Engineer Review

Test-list changes only. No test function changed.

  • Modified: tests/integration/test_lists/waives.txt (+1 line).
  • Waiver added: full:CPU/unittest/_torch/modeling_v2/test_modeling_v2_ci_selection.py::test_every_test_is_in_a_test_list SKIP (https://nvbugs/7082290).
  • Behavior affected: the CPU run of the selector test test_every_test_is_in_a_test_list is skipped. This test checks that every test belongs to a test list.
  • The PR reports no validation run for the waiver. The description asks reviewers to confirm the selector scope and the incident evidence separately.
  • Coverage verdict: needs follow-up. Coverage for the selector check on CPU is suspended until the linked bug closes and the waiver is removed.

Per-File QA Perspective

  • tests/integration/test_lists/waives.txt: Adds a CPU-only skip for test_every_test_is_in_a_test_list. QA should confirm that the skip is removed once NVBUG 7082290 is resolved and the test passes on CPU.

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@xxi-nv

xxi-nv commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

/bot skip --comment "waive the failure to unblock CI"

@github-actions

Copy link
Copy Markdown

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

@coderabbitai

coderabbitai Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The full CPU test list now skips test_every_test_is_in_a_test_list. The entry is linked to NVBUG 7082290.

Changes

CPU Test List Waiver

Layer / File(s) Summary
Add CPU test-list skip entry
tests/integration/test_lists/waives.txt
The full CPU test list adds a skip entry for test_every_test_is_in_a_test_list, associated with NVBUG 7082290.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: huigao-nv, crazydemo, xinhe-nv

Merge Risk: Minimal · up to 5df9e

This temporarily skips one CPU list-coverage test to unblock CI while the tracked bug is fixed. Production behavior is unaffected, and no merge-blocking risk was found.

Architecture risk: Low · up to 5df9e

The change affects 1 system.

Changed systems: tests

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — tests (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in tests/integration/test_lists/waives.txt: Adds the full CPU test-list skip entry for test_every_test_is_in_a_test_list, associated with NVBUG 7082290.
Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title uses the NVBugs ID and [infra] type, which follows the repository template. It names the main change: a temporary CPU waiver for one failed test case. It does not name the test, but it is re…
Description check Passed The description follows the repository template's main structure. It has a Description section that explains the waiver, the bug link, the scope, and the restore condition. The Test Coverage section i…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title uses the NVBugs ID and [infra] type, which follows the repository template. It names the main change: a temporary CPU waiver for one failed test case. It does not name the test, but it is related to the changeset and specific enough for a teammate to understand the primary change.

Full details: Description check

Explanation

The description follows the repository template's main structure. It has a Description section that explains the waiver, the bug link, the scope, and the restore condition. The Test Coverage section is filled with a review note rather than a list of relevant tests. The PR Checklist is present but unchecked, which the template allows for review. The description is mostly complete. It would be stronger with a short statement of why the test fails and which tests cover the waiver.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between e3c25b0 and 5df9ea7.

Files selected for processing: 1

  • tests/integration/test_lists/waives.txt

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #84271 [ skip ] triggered by Bot. Commit: 5df9ea7 Link to invocation

@xxi-nv
xxi-nv enabled auto-merge (squash) November 11, 2026 23:34
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #84271 [ skip ] completed with state SUCCESS. Commit: 5df9ea7
Skipping testing for commit 5df9ea7

Link to invocation

@xxi-nv
xxi-nv merged commit 762a8dc into NVIDIA:main Nov 11, 2026
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants